Custom Domains on Managed Environments#152
Merged
runefa merged 28 commits intocalvinsID:containerapp-0.3.12from Sep 15, 2022
Merged
Custom Domains on Managed Environments#152runefa merged 28 commits intocalvinsID:containerapp-0.3.12from
runefa merged 28 commits intocalvinsID:containerapp-0.3.12from
Conversation
Fix bug with `az containerapp create`
* Ran tests. * Update src/containerapp/azext_containerapp/_clients.py Co-authored-by: Silas Strawn <strawnsc@gmail.com> Co-authored-by: Haroon Feisal <haroonfeisal@microsoft.com> Co-authored-by: Silas Strawn <strawnsc@gmail.com>
`az containerapp up`: Support No Dockerfile Scenario
Revert "`az containerapp up`: Support No Dockerfile Scenario"
…dockerfile Revert "Revert "`az containerapp up`: Support No Dockerfile Scenario""
runefa
changed the base branch from
containerapp-0.3.11
to
containerapp-0.3.12
StrawnSC
approved these changes
Sep 15, 2022
Collaborator
StrawnSC
left a comment
StrawnSC
left a comment
There was a problem hiding this comment.
LGTM, just needs the linter fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json.